Skip to content

Comments

Add Windows64PGOTailcallBuild and Windows64PGONoGilTailcallBuild#667

Open
chris-eibl wants to merge 2 commits intopython:mainfrom
chris-eibl:msvc_tailcall
Open

Add Windows64PGOTailcallBuild and Windows64PGONoGilTailcallBuild#667
chris-eibl wants to merge 2 commits intopython:mainfrom
chris-eibl:msvc_tailcall

Conversation

@chris-eibl
Copy link
Member

@itamaro: I've created the new factories and used it for two new builders on your worker itamaro-win64-srv-22-aws.

If there is enough capacity, it would be fine to keep the the old builders, too, to have coverage for those configurations (which will be no longer released, though).

If there is not enough capacity, we'll have to clarify with @zooba whether we can ditch them or need to "find" a new worker.

I've put them into tier1, because that's what we're gonna release in the near future, and quoting Steve from our discord discussions

As long as all the configurations we actually release have a buildbot, it's fine (releases are gated on buildbots passing)

We only need this in the main branch, because MSVC tailcalling is not supported on the older branches. This is already ensured due to the Windows PGO prefix of the new builders:

ONLY_MAIN_BRANCH = (
    "ARM64 Windows",
    "Windows PGO",

I don't know whether this needs an issue here? Will create one if necessary.

@chris-eibl chris-eibl requested review from itamaro and vstinner and removed request for vstinner February 20, 2026 18:46
Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good!
I think worker capacity should be fine, but we'll find out after this lands. if we see capacity issues, maybe we can drop the 3.13 builds, since free-threading was experimental and we now have it supported in 3.14.
I don't think we can drop the non-tail-call builds for 3.14 and main, since these are the only buildbot debug builds we have for free-threading, given that tail-call on windows doesn't support debug.

Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!
I will merge this after I finish investigating a test isolation issue on that windows worker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants